-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(InputItem): add try catch to setSelection (#3120) #3124
Conversation
从根源上解决error |
Codecov Report
@@ Coverage Diff @@
## master #3124 +/- ##
=========================================
Coverage ? 60.24%
=========================================
Files ? 92
Lines ? 2269
Branches ? 651
=========================================
Hits ? 1367
Misses ? 893
Partials ? 9
Continue to review full report at Codecov.
|
根本原因是一些老内核下,有一些input type不支持selection api,所以这边catch住之后就做降级处理,不对光标做位置计算,回归老逻辑 |
相关issue #3120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)