Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(InputItem): add try catch to setSelection (#3120) #3124

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Fix(InputItem): add try catch to setSelection (#3120) #3124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d46f43
Fix(InputItem): add try catch to setSelection (#3120)
zack24q Mar 20, 2019
6e79781
Doc(InputItem): add MDN link
zack24q Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion components/input-item/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,12 @@ class InputItem extends React.Component<InputItemProps, any> {
case 'phone':
case 'number':
// controlled input type needs to adjust the position of the caret
el.selectionStart = el.selectionEnd = this.calcPos(prePos || 0, preCtrlVal, rawVal, ctrlValue, [' '], /\D/g)
try {
// set selection may throw error (https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/setSelectionRange)
el.selectionStart = el.selectionEnd = this.calcPos(prePos || 0, preCtrlVal, rawVal, ctrlValue, [' '], /\D/g);
} catch (error) {
console.warn('Set selection error:', error);
}
break;
default:
break;
Expand Down