Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer display error when viewport change size #11326

Closed
1 task
nuintun opened this issue Jul 18, 2018 · 9 comments
Closed
1 task

Drawer display error when viewport change size #11326

nuintun opened this issue Jul 18, 2018 · 9 comments
Assignees
@chenshuai2144

Comments

@nuintun
Copy link
Contributor

nuintun commented Jul 18, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.7.0

Environment

WIN10 - Chome67 - React 16

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Open and close in small size viewport, then change viewport to big size.

What is expected?

Drawer display ok

What is actually happening?

Percent display error

drawer
@chenshuai2144
Copy link
Contributor

@jljsj33 look

@jljsj33
Copy link
Member

jljsj33 commented Jul 18, 2018

说中文

@jljsj33
Copy link
Member

jljsj33 commented Jul 18, 2018

没监听 resize 的问题。。。

@jljsj33
Copy link
Member

jljsj33 commented Jul 18, 2018

@afc163 点表情挺快哦，，呀的。。一堆中国人讲着中式英文，，，为什么不能让老外用谷歌翻译。。。

@afc163
Copy link
Member

afc163 commented Jul 18, 2018

不要监听 resize，用纯样式解决。

@jljsj33
Copy link
Member

jljsj33 commented Jul 18, 2018

我知道，，antd 的好像不需要转换成 px,,我看看能否用 %。。。

@afc163
Copy link
Member

afc163 commented Jul 18, 2018

用 translateX(100%) 或者 right: 0。

@jljsj33
Copy link
Member

jljsj33 commented Jul 18, 2018

不用 right ，，，手机上会跑不动。。。

jljsj33 added a commit to react-component/drawer that referenced this issue Jul 18, 2018
@jljsj33
fix vw, be ant-design/ant-design#11326
e51f482
@jljsj33 jljsj33 mentioned this issue Jul 18, 2018
Merged
jljsj33 added a commit to react-component/drawer that referenced this issue Jul 18, 2018
@jljsj33
fix vw, be ant-design/ant-design#11326
ac1dc8b
@jljsj33 jljsj33 mentioned this issue Jul 19, 2018
Merged
@chenshuai2144
Copy link
Contributor

fix in #11356

bors bot referenced this issue in mozilla/delivery-console Jul 25, 2018
@bors @renovate-bot
Merge #319
16abeb9 
319: Update dependency antd to v3.7.2 r=magopian a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.7.1` to `v3.7.2`



<details>
<summary>Release Notes</summary>

### [3.7.2](https://github.com/ant-design/ant-design/releases/3.7.2)
[Compare Source](ant-design/ant-design@3.7.1...3.7.2)
- DatePicker
  - 🐞 **Fix issue resulting in year and month can not be changed in control mode.** [b9992f4](ant-design/ant-design@b9992f4)
  - 🐞 Fix warning of `getDerivedStateFromProp`. [#&#8203;11398](`https://github.com/ant-design/ant-design/pull/11398`) [@&#8203;yoyo837]
- Drawer
  - 🐞 Fix close animation when setting `destroyOnClose`. [#&#8203;11307](`https://github.com/ant-design/ant-design/issues/11307`)
  - 🐞 Fix display issue when using a `vw` value as `width`. [#&#8203;11326](`https://github.com/ant-design/ant-design/issues/11326`)
  - 🐞 Fix `wrapClassName` now working.
- 🐞 Fix text overflow of Tooltip. [#&#8203;11402](`https://github.com/ant-design/ant-design/pull/11402`) [@&#8203;weidapao]
- 🐞 Fix style issue of dark theme Menu in Layout.Header. [#&#8203;11400](`https://github.com/ant-design/ant-design/pull/11400`) [@&#8203;hongxuWei]
- 🐞 Fix the arrow buttons of InputNumber showing wrong positon in a fixed table. [#&#8203;11408](`https://github.com/ant-design/ant-design/issues/11408`)
- 🐞 Fix issue resulting in Select.Option shows wrong border radius in Select.OptGroup. [6cb6f5c](ant-design/ant-design@6cb6f5c)
- 🐞 Fix issue resulting in `onChange` was trigged twice when click the filter icon of Table. [#&#8203;11164](`https://github.com/ant-design/ant-design/issues/11164`) [@&#8203;adybionka]
- 🐞 Fix issue resulting title of Model.confirm shows scrollbar on Firefox. [#&#8203;11432](`https://github.com/ant-design/ant-design/issues/11432`)
- TypeScript
  - 🐞 Fix type definition of Radio.Group. [#&#8203;11409](`https://github.com/ant-design/ant-design/pull/11409`) [@&#8203;eddiemoore]
  - 🐞 Fix type definition of TreeSelect. [#&#8203;11442](`https://github.com/ant-design/ant-design/pull/11442`) [@&#8203;JribiBelhassen]
  - 🐞 Fix type definition of Badge. [#&#8203;11421](`https://github.com/ant-design/ant-design/pull/11421`) [@&#8203;zongzi531]


---


- DatePicker
  - 🐞 **修复在受控模式下不能切换年月的问题。**[b9992f4](ant-design/ant-design@b9992f4)
  - 🐞 修复在 `getDerivedStateFromProp` 的警告。[#&#8203;11398](`https://github.com/ant-design/ant-design/pull/11398`) [@&#8203;yoyo837]
- Drawer
  - 🐞 修复使用 `destroyOnClose` 时没有关闭动画的问题。[#&#8203;11307](`https://github.com/ant-design/ant-design/issues/11307`)
  - 🐞 修复 `width` 以 `vw` 为单位时的显示错误。[#&#8203;11326](`https://github.com/ant-design/ant-design/issues/11326`)
  - 🐞 修复 `wrapClassName` 属性无效的问题。
- 🐞 修复 Tooltip 文字溢出的问题。[#&#8203;11402](`https://github.com/ant-design/ant-design/pull/11402`) [@&#8203;weidapao]
- 🐞 修复 Menu 在 `theme` 为 `dark` 是在 Layout.Header 里的样式问题。[#&#8203;11400](`https://github.com/ant-design/ant-design/pull/11400`) [@&#8203;hongxuWei]
- 🐞 修复 InputNumber 的箭头按钮在使用了固定列的 Table 里显示错位的问题。[#&#8203;11408](`https://github.com/ant-design/ant-design/issues/11408`)
- 🐞 修复 Select 使用分组时 Option 的圆角显示错误。[6cb6f5c](ant-design/ant-design@6cb6f5c)
- 🐞 修复 Table 第一次点击过滤按钮的时候 `onChange` 会被触发两次的问题。[#&#8203;11164](`https://github.com/ant-design/ant-design/issues/11164`) [@&#8203;adybionka]
- 🐞 修复 Model.confirm 的标题在 Firefox 下会显示滚动条的问题。[#&#8203;11432](`https://github.com/ant-design/ant-design/issues/11432`)
- TypeScript
  - 🐞 修复 Radio.Group 类型定义。[#&#8203;11409](`https://github.com/ant-design/ant-design/pull/11409`) [@&#8203;eddiemoore]
  - 🐞 修复 TreeSelect 类型定义。[#&#8203;11442](`https://github.com/ant-design/ant-design/pull/11442`) [@&#8203;JribiBelhassen]
  - 🐞 修复 Badge 类型定义。[#&#8203;11421](`https://github.com/ant-design/ant-design/pull/11421`) [@&#8203;zongzi531]

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenshuai2144 chenshuai2144

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@afc163 @nuintun @jljsj33 @chenshuai2144