Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vw #27

Merged
merged 7 commits into from
Jul 19, 2018
Merged

Fix vw #27

merged 7 commits into from
Jul 19, 2018

Conversation

jljsj33
Copy link
Member

@jljsj33 jljsj33 commented Jul 18, 2018

@jljsj33 jljsj33 requested review from afc163 and chenshuai2144 July 18, 2018 11:55
@jljsj33
Copy link
Member Author

jljsj33 commented Jul 18, 2018

@chenshuai2144 现在抽屉的动画改成用 %, 还有增加 width 和 height, 只针对有推移时除抽屉外其它元素的一个位移的距离设置。你可以不改你的 API, antd 里没这需求。。。

@codecov-io
Copy link

codecov-io commented Jul 18, 2018

Codecov Report

Merging #27 into master will increase coverage by 0.39%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   75.65%   76.05%   +0.39%     
==========================================
  Files           3        3              
  Lines         304      309       +5     
  Branches      103      108       +5     
==========================================
+ Hits          230      235       +5     
  Misses         69       69              
  Partials        5        5
Impacted Files Coverage Δ
src/utils.js 75.75% <ø> (+1.56%) ⬆️
src/Drawer.js 76% <94.73%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1d5e2...62ede00. Read the comment docs.

@jljsj33
Copy link
Member Author

jljsj33 commented Jul 18, 2018

@chenshuai2144 依赖里改下 1.6.0, 我发 1.6.0

@chenshuai2144
Copy link
Contributor

发个 pr 我测试一下,下个版本

@jljsj33 jljsj33 merged commit d589297 into master Jul 19, 2018
@jljsj33 jljsj33 deleted the fix-vw branch July 19, 2018 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants