Fix race condition in unit test for IPsec #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4060 +/- ##
==========================================
+ Coverage 64.09% 67.30% +3.21%
==========================================
Files 294 297 +3
Lines 44161 44434 +273
==========================================
+ Hits 28305 29908 +1603
+ Misses 13548 12167 -1381
- Partials 2308 2359 +51
|
tnqn
reviewed
Jul 28, 2022
| signCh := make(chan struct{}) | ||
| defer func() { | ||
| <-signCh | ||
| }() |
There was a problem hiding this comment.
if the next line returns an error, the code will block forever?
There was a problem hiding this comment.
Moved the defer func below the watcher error check. Thanks!
Wait for the signer goroutine to finish before quitting the tests. This ensures that the *testing.T is always valid in the signer. Fixes: antrea-io#4059 Signed-off-by: Xu Liu <[email protected]>
xliuxu
force-pushed
the
fix_ipsec_ut_race
branch
from
3dd2d30 to
593c0bc
Compare
wenyingd
reviewed
Jul 29, 2022
pkg/agent/controller/ipseccertificate/ipsec_certificate_controller_test.go
Show resolved
Hide resolved
tnqn
approved these changes
Jul 29, 2022
|
/skip-all |
|
/skip-conformance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the signer goroutine to finish before quitting the tests.
This ensures that the *testing.T is always valid in the signer.
Fixes: #4059
Signed-off-by: Xu Liu [email protected]