Automated cherry pick of #4016: Fix unit test flaky for IPsec controller #4060: Fix race condition in unit test for IPsec #4241: Fix flaky TestController_RotateCertificates unit test #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait one second as the fake clientset doesn't support watching with specific resourceVersion. Otherwise the update event would be missed by the watcher used in csrutil.WaitForCertificate() if it happens to be generated in-between the List and Watch calls. Fixes: antrea-io#3851 Signed-off-by: Xu Liu <[email protected]>
Wait for the signer goroutine to finish before quitting the tests. This ensures that the *testing.T is always valid in the signer. Fixes: antrea-io#4059 Signed-off-by: Xu Liu <[email protected]>
The difference in CSR CreationTimestamp can be lower than 7s because the resolution of the certificate's NotAfter field is at the second level, which means the provided expiration time will be truncated. Fixes antrea-io#4224 Signed-off-by: Antonin Bas <[email protected]>
xliuxu
added
the
kind/cherry-pick
Codecov Report
@@ Coverage Diff @@
## release-1.7 #4483 +/- ##
===============================================
+ Coverage 62.99% 63.13% +0.13%
===============================================
Files 293 293
Lines 43460 43460
===============================================
+ Hits 27379 27437 +58
+ Misses 13877 13833 -44
+ Partials 2204 2190 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
approved these changes
Dec 14, 2022
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #4016 #4060 #4241 on release-1.7.
#4016: Fix unit test flaky for IPsec controller
#4060: Fix race condition in unit test for IPsec
#4241: Fix flaky TestController_RotateCertificates unit test
For details on the cherry pick process, see the cherry pick requests page.