Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestController_RotateCertificates unit test #4241

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Fix flaky TestController_RotateCertificates unit test #4241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pkg/agent/controller/ipseccertificate/ipsec_certificate_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,16 @@ func TestController_RotateCertificates(t *testing.T) {
if delta < 0 {
delta = -delta
}
// the rotation interval should be in [7s, 9s], but it takes time to process the CSR request,
// so add one second to the upper bound.
assert.Less(t, delta, time.Second*10)
assert.LessOrEqual(t, time.Second*7, delta)
// the rotation interval is determined by nextRotationDeadline as notBefore + (notAfter -
// notBefore) * k, where k is >= 0.7 and <= 0.9. We would therefore expect the delta to
// fall in the interval [7s, 9s]. However we have to account for the following:
// a) the accuracy of notAfter is at the second level, which means that it will be
// truncated, which means that there can actually be less than 7s between the
// CreationTimestamp of the first certificate and the rotation deadline. As a result, we
// need to set the lower bound to 6s.
// b) it takes time to process the CSR request so we add one second to the upper bound.
assert.Less(t, delta, 10*time.Second)
assert.LessOrEqual(t, 6*time.Second, delta)
}

func newIPsecCertTemplate(t *testing.T, nodeName string, notBefore, notAfter time.Time) *x509.Certificate {
Expand Down