Fix flaky TestController_RotateCertificates unit test #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The difference in CSR CreationTimestamp can be lower than 7s because the resolution of the certificate's NotAfter field is at the second level, which means the provided expiration time will be truncated. Fixes antrea-io#4224 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added
area/test
xliuxu
approved these changes
Sep 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #4241 +/- ##
==========================================
- Coverage 64.29% 60.26% -4.03%
==========================================
Files 361 385 +24
Lines 52203 54471 +2268
==========================================
- Hits 33563 32828 -735
- Misses 16186 19176 +2990
- Partials 2454 2467 +13
|
tnqn
approved these changes
Sep 21, 2022
|
/skip-all |
1 similar comment
|
/skip-all |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
The difference in CSR CreationTimestamp can be lower than 7s because the resolution of the certificate's NotAfter field is at the second level, which means the provided expiration time will be truncated. Fixes antrea-io#4224 Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference in CSR CreationTimestamp can be lower than 7s because the resolution of the certificate's NotAfter field is at the second level, which means the provided expiration time will be truncated.
Fixes #4224
Signed-off-by: Antonin Bas [email protected]