Ensure that promote_secondaries is set on IPAssigner interfaces #6898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
kind/bug
The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used). Fixes antrea-io#6890 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
set-promote_secondaries-in-ip-assigner
branch
from
472aa34 to
c46177f
Compare
antoninbas
commented
Jan 3, 2025
| // instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address | ||
| // can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to | ||
| // be the primary (first one assigned chronologically). | ||
| if err := util.EnsurePromoteSecondariesOnInterface(name); err != nil { |
There was a problem hiding this comment.
@tnqn I added this here to match the call to EnsureRPFilterOnInterface, but it feels like we could move these calls to addVLANAssignee, so that they are called when the antrea-agent restarts. What do you think?
There was a problem hiding this comment.
Yes, it makes more sense to move them to addVLANAssignee, as there is no guarantee EnsureRPFilterOnInterface has executed once when the vlan interface is found.
There was a problem hiding this comment.
I will move both calls together in a follow-up PR.
There was a problem hiding this comment.
Follow-up PR: #6900
| // instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address | ||
| // can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to | ||
| // be the primary (first one assigned chronologically). | ||
| if err := util.EnsurePromoteSecondariesOnInterface(deviceName); err != nil { |
There was a problem hiding this comment.
it makes sense to set this on the dummy interface IMO, but this is not likely to affect any of our use cases
There was a problem hiding this comment.
Out of curiosity, is it because the IPs on the dummy interface have /32 mask, hence not in the same subnet?
There was a problem hiding this comment.
That was my thinking, but I have since realized that it is possible to create an ExternalIPPool with a subnetInfo and without a VLAN ID. In this case, the IP will be addressed to the dummy interface (antrea-egress0) with the prefix length specified in the subnetInfo.
For example:
apiVersion: crd.antrea.io/v1beta1
kind: ExternalIPPool
metadata:
name: eip
spec:
ipRanges:
- start: 10.10.0.2
end: 10.10.0.10
subnetInfo:
gateway: 10.10.0.1
prefixLength: 24
nodeSelector: {}After creating a couple of Egresses, the following can be observed on the Node:
5: antrea-egress0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN group default
link/ether 6e:44:5f:08:02:e6 brd ff:ff:ff:ff:ff:ff
inet 10.10.0.2/24 brd 10.10.0.255 scope global antrea-egress0
valid_lft forever preferred_lft forever
inet 10.10.0.4/24 brd 10.10.0.255 scope global secondary antrea-egress0
valid_lft forever preferred_lft forever
Prior to the EgressSeparateSubnet feature, all assigned IPs would be /32, so Egress IPs would never be "secondary" aliases and the problem did not exist.
antoninbas
added
kind/cherry-pick
tnqn
approved these changes
Jan 6, 2025
| // instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address | ||
| // can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to | ||
| // be the primary (first one assigned chronologically). | ||
| if err := util.EnsurePromoteSecondariesOnInterface(deviceName); err != nil { |
There was a problem hiding this comment.
Out of curiosity, is it because the IPs on the dummy interface have /32 mask, hence not in the same subnet?
| // instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address | ||
| // can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to | ||
| // be the primary (first one assigned chronologically). | ||
| if err := util.EnsurePromoteSecondariesOnInterface(name); err != nil { |
There was a problem hiding this comment.
Yes, it makes more sense to move them to addVLANAssignee, as there is no guarantee EnsureRPFilterOnInterface has executed once when the vlan interface is found.
|
/test-all |
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Jan 8, 2025
…ea-io#6898) The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used). Fixes antrea-io#6890 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Jan 8, 2025
…ea-io#6898) The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used). Fixes antrea-io#6890 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Jan 8, 2025
…ea-io#6898) The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used). Fixes antrea-io#6890 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Jan 10, 2025
The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used). Fixes #6890 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Jan 10, 2025
The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used). Fixes #6890 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Jan 10, 2025
The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used). Fixes #6890 Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used).
Fixes #6890