Automated cherry pick of #6898: Ensure that promote_secondaries is set on IPAssigner #6900: Ensure correct sysctl values if VLAN iface exists in #6910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ea-io#6898) The IPAssigner should ensure that the promote_secondaries sysctl variable is always set when creating an interface. This ensures that When the primary IP address is removed from the interface, a secondary IP address is promoted, instead of removing all the corresponding secondary IP addresses. Otherwise, the deletion of one IP address can trigger the automatic removal of all other IP addresses in the same subnet, if the deleted IP happens to be the primary (first one assigned chronologically). For example, this can affect the Egress feature (when EgressSeparateSubnet is used). Fixes antrea-io#6890 Signed-off-by: Antonin Bas <[email protected]>
…ea-io#6900) If the VLAN interface already exixts (e.g., in case of an Agent restart), we should still ensure that the necessary systcl variables are set correctly. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added
the
kind/cherry-pick
tnqn
approved these changes
Jan 9, 2025
antoninbas
deleted the
automated-cherry-pick-of-#6898-#6900-upstream-release-2.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #6898 #6900 on release-2.1.
#6898: Ensure that promote_secondaries is set on IPAssigner
#6900: Ensure correct sysctl values if VLAN iface exists in
For details on the cherry pick process, see the cherry pick requests page.