-
Notifications
You must be signed in to change notification settings - Fork 272
feat(plugin-chart-echarts): Echarts Waterfall #1150
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/FJbino8EN3i1DjaNk6njydZ9RfP6 |
Thanks stephen. |
7feb21b
to
bb49811
Compare
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
+ Coverage 30.03% 30.41% +0.37%
==========================================
Files 489 495 +6
Lines 9854 9958 +104
Branches 1654 1680 +26
==========================================
+ Hits 2960 3029 +69
- Misses 6653 6678 +25
- Partials 241 251 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildQuery, | ||
controlPanel, | ||
loadChart: () => import('./EchartsWaterfall'), | ||
metadata: new ChartMetadata({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs category property here. Might Ranking
is is an appropriate category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evolution
seems reasonable to me.
bb49811
to
83cb0ea
Compare
The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:
If you need help with the migration, please post a message on the SIP or reach out on the community Slack. |
🏆 Enhancements
Waterfall charts are useful for understanding how an initial value (like net income) is affected by a series of positive and negative changes.
For example, we can see the trend of personal annual income. Here we use the year as the
![image](https://user-images.githubusercontent.com/11830681/120924226-1d94ff80-c705-11eb-8adf-a7da594a5599.png)
series
.Moreover, we can use the value in
![image](https://user-images.githubusercontent.com/11830681/120893346-68e7d900-c645-11eb-8afe-e55290cbf754.png)
breakdowns
to add additional data to the chart. It adds the contributors to increases or decreases for each series.This pr refers to #705 (Thanks for Simcha's work.