-
Notifications
You must be signed in to change notification settings - Fork 272
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2s0hwtinr |
5b77153
to
921664c
Compare
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 24.19% 24.87% +0.68%
==========================================
Files 339 348 +9
Lines 7617 7738 +121
Branches 925 950 +25
==========================================
+ Hits 1843 1925 +82
- Misses 5701 5733 +32
- Partials 73 80 +7
Continue to review full report at Codecov.
|
Thanks for the great contribution, @amitNielsen ! Since we have plans to move Superset to ECharts, do you mind checking how much work would it be to reimplement the same visualization in ECharts? |
@ktmud in one of our community meetup it was concluded that although core plugins pack will be implemented in ECharts there would be other plugin pack and that it totally ok. Ours going towards recharts |
feat: Add Waterfall Chart plugin.
Chart Images:
Initial:
Cross filter example:
Description:
This feature add new plugin of Waterfall Chart that using
Recharts
library to build this chart.In Control panel it adds to fields:
xAxisColumn
andperiodColumn
that will be passed asgroupBy
columns to the DB to get data.