Removes race conditions between tablet refresh and minor compaction #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moved the tablet twoards using a TabletMetadata object as the source of the tablets files instead of tracking the files itself. The move twoards using TabletMetadata support the changes to fix the race conditions with tablet refresh. Committing a minor compaction to walogs and the metadata table is now mutually exclusive with refreshing a tablets metadata. Scans should always see a consistent view of the in memory maps a tablet has and the files it has after this change. Before this change a tablet scan could see the file produced by a minor compaction and the in memory map that was the source of that file. Scans should only see one or the other. fixes apache#3625
dlmarion
reviewed
Jul 19, 2023
|
FYI - it looks like spot bugs flagged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moved the tablet twoards using a TabletMetadata object as the source of the tablets files instead of tracking the files itself. The move twoards using TabletMetadata support the changes to fix the race conditions with tablet refresh. Committing a minor compaction to walogs and the metadata table is now mutually exclusive with refreshing a tablets metadata. Scans should always see a consistent view of the in memory maps a tablet has and the files it has after this change. Before this change a tablet scan could see the file produced by a minor compaction and the in memory map that was the source of that file. Scans should only see one or the other.
fixes #3625