Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes race conditions between tablet refresh and minor compaction #3634

Merged
merged 3 commits into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -640,8 +640,6 @@ public enum Property {
+ " minor compacted file because it may have been modified by iterators. The"
+ " file dumped to the local dir is an exact copy of what was in memory.",
"1.3.5"),
TSERV_HEALTH_CHECK_FREQ("tserver.health.check.interval", "30m", PropertyType.TIMEDURATION,
"The time between tablet server health checks.", "2.1.0"),
TSERV_MINTHREADS("tserver.server.threads.minimum", "20", PropertyType.COUNT,
"The minimum number of threads to use to handle incoming requests.", "1.4.0"),
TSERV_MINTHREADS_TIMEOUT("tserver.server.threads.timeout", "0s", PropertyType.TIMEDURATION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,14 @@ public static void bulkImported(KeyExtent extent, TabletFile file) {
fileLog.debug("Imported {} {} ", extent, file);
}

public static void recovering(KeyExtent extent, List<LogEntry> logEntries) {
public static void recovering(KeyExtent extent, Collection<LogEntry> logEntries) {
if (recoveryLog.isDebugEnabled()) {
List<String> logIds = logEntries.stream().map(LogEntry::getUniqueID).collect(toList());
recoveryLog.debug("For {} recovering data from walogs: {}", extent, logIds);
}
}

public static void recovered(KeyExtent extent, List<LogEntry> logEntries, long numMutation,
public static void recovered(KeyExtent extent, Collection<LogEntry> logEntries, long numMutation,
long numEntries) {
recoveryLog.info("For {} recovered {} mutations creating {} entries from {} walogs", extent,
numMutation, numEntries, logEntries.size());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,5 +124,4 @@ public static void validate(String metadataEntry) {
public static StoredTabletFile of(final String metadataEntry) {
return new StoredTabletFile(metadataEntry);
}

}
Loading