Add EmitWarningsOnPlaceholders("age") #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2024
|
@shinyaaa Please add in regression tests to show this works :) |
jrgemignani
requested changes
Aug 1, 2024
shinyaaa
force-pushed
the
add-emit-warnings-on-placeholders
branch
3 times, most recently
from
eb403e7 to
a01b8cb
Compare
|
Thanks for the review. |
|
@shinyaaa Overall looks good. Before it can be merged, could you please add detailed commit message as well? |
shinyaaa
changed the title
|
Thank you! I've set up a commit message. And the same goes for other PRs. |
jrgemignani
approved these changes
Aug 5, 2024
|
Hi @shinyaaa, your commit message is applied to the PR in GitHub rather than the commit. To clarify, I meant adding extended commit message after you run the |
Added EmitWarningsOnPlaceholders("age") to warn when an undefined GUC parameter is set for a placeholder named "age".
Warnings are issued when PostgreSQL starts and when SET statements are executed.
When PostgreSQL starts
```
2024-08-01 18:32:31.220 JST [2039799] WARNING: invalid configuration parameter name "age.invalid_parameter", removing it
```
When SET statement is executed
```
ERROR: invalid configuration parameter name "age.invalid_parameter"
DETAIL: "age" is a reserved prefix.
```
Regression tests were added.
shinyaaa
force-pushed
the
add-emit-warnings-on-placeholders
branch
from
a01b8cb to
bb83865
Compare
|
Added the commit message, and rebased. |
|
@shinyaaa Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EmitWarningsOnPlaceholders("age") to warn when an undefined GUC parameter is set for a placeholder named "age".
Warnings are issued when PostgreSQL starts and when SET statements are executed.
When PostgreSQL starts
When SET statement is executed
Regression tests were added.