Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on July 06, 2023 #32389

Closed
44 of 69 tasks
eladkal opened this issue Jul 6, 2023 · 24 comments
Closed
44 of 69 tasks

Status of testing Providers that were prepared on July 06, 2023 #32389

eladkal opened this issue Jul 6, 2023 · 24 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented Jul 6, 2023

Body

Issue title: Status of testing Providers that were prepared on July 06, 2023

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider alibaba: 2.5.0rc2

Provider amazon: 8.3.0rc2

Provider apache.hive: 6.1.2rc2

Provider apache.impala: 1.1.2rc2

Provider apache.kafka: 1.1.2rc2

Provider apache.livy: 3.5.2rc2

Provider cncf.kubernetes: 7.2.0rc2

Provider common.sql: 1.6.0rc2

Provider databricks: 4.3.1rc2

Provider dbt.cloud: 3.2.2rc2

Provider elasticsearch: 5.0.0rc2

Provider google: 10.3.0rc2

Provider hashicorp: 3.4.2rc2

Provider microsoft.azure: 6.2.0rc2

Provider postgres: 5.5.2rc2

Provider snowflake: 4.3.0rc2

Provider trino: 5.2.0rc2

Provider vertica: 3.5.0rc2

The guidelines on how to test providers can be found in

Verify providers by contributors

All users involved in the PRs:
@darkag @raphaelauv @blcksrx @vandonr-amz @jhbigler @potiuk @Lee-W @bkossakowska @nathadfield @dcoliversun @phanikumv @pankajastro @aagateuip @joaopamaral @Adaverse @JDarDagran @moiseenkov @Joffreybvn
@eladi99 @hussein-awala @notatallshaw-gts @Owen-CH-Leung @shahar1 @eladkal @utkarsharma2 @sunank200 @syedahsn @kristopherkane @cjames23 @ahidalgob @HaeSe0ng

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels Jul 6, 2023
@Joffreybvn
Copy link
Contributor

#32304 Works fine. Kerberos is installed when doing pip install apache-airflow-providers-apache-impala[kerberos]

@JDarDagran
Copy link
Contributor

#32345 works fine - tested both with hook_params and deprecated runtime_parameters.
#31398 , #32371 are added too. There's however a bug fixed in #32400 which is not exposed though as there's no release of OpenLineage provider yet (method with a bug is never called without the OL provider). Would be nice to include this in this release cycle, I guess?

github-actions bot pushed a commit to astronomer/astronomer-providers that referenced this issue Jul 6, 2023
@eladkal
Copy link
Contributor Author

eladkal commented Jul 6, 2023

There's however a bug fixed in #32400 which is not exposed though as there's no release of OpenLineage provider yet (method with a bug is never called without the OL provider). Would be nice to include this in this release cycle, I guess?

Thanks for verifying
This is not a blocker for this release since the OL integration doesn't work anyway (as OL provider is not yet available) the bug is locallized to OL part.
For the moment I see no reason to have RC3, The fix will be included in future release of the provider.

github-actions bot pushed a commit to astronomer/astronomer-providers that referenced this issue Jul 6, 2023
@Lee-W
Copy link
Member

Lee-W commented Jul 6, 2023

We tested our example, DAGs with the following rc without encountering any error

  • apache-airflow-providers-amazon
  • apache-airflow-providers-apache-hive
  • apache-airflow-providers-apache-livy
  • apache-airflow-providers-cncf-kubernetes
  • apache-airflow-providers-databricks
  • apache-airflow-providers-dbt-cloud
  • apache-airflow-providers-google
  • apache-airflow-providers-microsoft-azure
  • apache-airflow-providers-snowflake

@pankajkoti
Copy link
Member

For #31920 I have a question which I have asked here #31920 (comment)

@darkag
Copy link
Contributor

darkag commented Jul 6, 2023

tested #32089, works as expected

@vandonr-amz
Copy link
Contributor

good for me, even if I'd prefer an RC3 to sneak some not-yet-breaking changes in there.

@Adaverse
Copy link
Contributor

Adaverse commented Jul 6, 2023

Tested #32126 #31783 #32082 #32120 #32322 works as expected.

@potiuk
Copy link
Member

potiuk commented Jul 6, 2023

Checked #32334 👍

image

vs (6.2.1)

image

Lee-W added a commit to astronomer/astronomer-providers that referenced this issue Jul 7, 2023
Lee-W added a commit to astronomer/astronomer-providers that referenced this issue Jul 7, 2023
@dcoliversun
Copy link
Contributor

Checked #31787, thanks for your work @eladkal

  • ADB Spark is installed when apache-airflow-providers-alibaba==2.5.0rc2
  • DAGs works fine
    image

@eladkal
Copy link
Contributor Author

eladkal commented Jul 7, 2023

Tested #32126 #31783 #32082 #32120 #32322 works as expected.

Can you also check 32270 ?

@phanikumv
Copy link
Contributor

#32034 and #31872 are working fine

@jhbigler
Copy link
Contributor

jhbigler commented Jul 7, 2023

#31950 is working, I used apache-airflow-providers-trino==5.2.0rc2 and tested it against our development trino instance, I can verify the Trino hook reads the jwt file from disk and successfully authenticates with trino.

@Adaverse
Copy link
Contributor

Adaverse commented Jul 7, 2023

Tested #32126 #31783 #32082 #32120 #32322 works as expected.

Can you also check 32270 ?

Tested with the above versions of providers of Amazon and Microsoft #32270 works as expected. Thanks, @eladkal

@kristopherkane
Copy link
Contributor

Tested #32216 in local Airflow against real GCP Dataproc jobs.

@eladkal
Copy link
Contributor Author

eladkal commented Jul 7, 2023

Amazon and Elasticsearch are excluded from RC2 (RC3 will be cut seperatly)
The rest of providers are not affected

@utkarsharma2
Copy link
Contributor

utkarsharma2 commented Jul 8, 2023 via email

@hussein-awala
Copy link
Member

I have tested my changes and all of them work as expected. For #31803, it addresses a part of the problem, but there are still remaining issues in some use cases that need to be resolved, however no need for a new RC, we can release them in next releases, and the merged PR is necessary.

@eladkal
Copy link
Contributor Author

eladkal commented Jul 9, 2023

Thank you everyone.
Providers are released except Amazon and Elasticsearch which we will have RC3.

I invite everyone to help improve providers for the next release, a list of open issues can be found here.

@raphaelauv
Copy link
Contributor

Hey , I did not test on time the K8S providers -> there is a bug on the release

#32458

@eladkal
Copy link
Contributor Author

eladkal commented Jul 9, 2023

Hey , I did not test on time the K8S providers -> there is a bug on the release

#32458

Provider already released. When fix is merged it will be released in the next provider wave

@potiuk
Copy link
Member

potiuk commented Jul 9, 2023

Provider already released. When fix is merged it will be released in the next provider wave

We could consider yanking it.

@eladkal
Copy link
Contributor Author

eladkal commented Jul 10, 2023

We could consider yanking it.

We shouldn't
I don't think its a major bug and if we yank kubernetes we must also yank google and cancel amazon rc4 (currently in vote) as they use new feature released in kubernetes provider.

I will cut new release for kubernetes as soon as possible (can't right now because we have another provider vote in progress)

Lee-W added a commit to astronomer/astronomer-providers that referenced this issue Jul 10, 2023
@potiuk
Copy link
Member

potiuk commented Jul 10, 2023

Sure. No problem with that :)

Lee-W added a commit to astronomer/astronomer-providers that referenced this issue Jul 10, 2023
Lee-W added a commit to astronomer/astronomer-providers that referenced this issue Jul 11, 2023
airflow-oss-bot added a commit to astronomer/astronomer-providers that referenced this issue Aug 11, 2023
airflow-oss-bot added a commit to astronomer/astronomer-providers that referenced this issue Aug 11, 2023
airflow-oss-bot added a commit to astronomer/astronomer-providers that referenced this issue Aug 11, 2023
github-actions bot pushed a commit to astronomer/astro-sdk that referenced this issue Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests