Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KubernetesPodTrigger waiting strategy #31348

Merged
merged 7 commits into from
Jun 29, 2023

Conversation

hussein-awala
Copy link
Member

closes: #31335

This PR waits for the pod to reach a terminated state before triggering a success event and resuming the task.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues area:providers labels May 17, 2023
@hussein-awala hussein-awala marked this pull request as ready for review May 17, 2023 11:28
@hussein-awala hussein-awala requested a review from ashb May 17, 2023 11:31
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would prefer someone else who knows more about async triggers and k8s to approve it.

@hussein-awala
Copy link
Member Author

@jedcunningham could you review this PR?

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit 8f5de83 into apache:main Jun 29, 2023
hussein-awala added a commit to hussein-awala/airflow that referenced this pull request Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KPO deferable "random" false fail
3 participants