Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump moto version #22099

Merged
merged 1 commit into from
Mar 9, 2022
Merged

bump moto version #22099

merged 1 commit into from
Mar 9, 2022

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Mar 8, 2022

We had to pin responses due to issue with moto lib #22046

moto fixed the problem getmoto/moto#4913 in 3.0.7 so we can just bump moto and drop the responses limit.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@eladkal eladkal requested a review from potiuk March 8, 2022 20:41
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to refresh constraints manually to merge this one, but yes :)

@potiuk potiuk closed this Mar 8, 2022
@potiuk potiuk reopened this Mar 8, 2022
@potiuk
Copy link
Member

potiuk commented Mar 8, 2022

Temp doc build problem. Reopend to rebuild.

@eladkal
Copy link
Contributor Author

eladkal commented Mar 8, 2022

mmm I see the doc build is still failing with:

  apache-airflow                                               Traceback (most recent call last):
  apache-airflow                                                 File "/usr/local/lib/python3.7/site-packages/sphinx/registry.py", line 433, in load_extension
  apache-airflow                                                   mod = import_module(extname)
  apache-airflow                                                 File "/usr/local/lib/python3.7/importlib/__init__.py", line 127, in import_module
  apache-airflow                                                   return _bootstrap._gcd_import(name, package, level)
  apache-airflow                                                 File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  apache-airflow                                                 File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  apache-airflow                                                 File "<frozen importlib._bootstrap>", line 965, in _find_and_load_unlocked
  apache-airflow                                               ModuleNotFoundError: No module named 'sphinxcontrib.jinja'

and sphinx-jinja released version 1 hour ago
https://pypi.org/project/sphinx-jinja/#history

@eladkal eladkal mentioned this pull request Mar 8, 2022
@eladkal
Copy link
Contributor Author

eladkal commented Mar 8, 2022

I'll rebase after either #22101 or #22100 merged and to resolve the sphinx issue.

@eladkal
Copy link
Contributor Author

eladkal commented Mar 9, 2022

rebased

@potiuk
Copy link
Member

potiuk commented Mar 9, 2022

Generating constraints so that we can merge and push constraints at once (BTW. I am going to automate this case soon ).

@potiuk
Copy link
Member

potiuk commented Mar 9, 2022

Actually moto has already been updated to latest version so we can merge it stratight away witthout re-generating constraints :);

@potiuk potiuk merged commit 60ec508 into apache:main Mar 9, 2022
@eladkal eladkal deleted the moto branch March 9, 2022 09:26
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Apr 11, 2022
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants