Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit sphinx-jinja #22100

Closed
wants to merge 2 commits into from
Closed

limit sphinx-jinja #22100

wants to merge 2 commits into from

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Mar 8, 2022

sphinx-jinja release new major version which fails our doc build
https://pypi.org/project/sphinx-jinja/#history
causing PRs to fail on doc build:
#22099

we can remove the limit when we will apply the fix needed as explained in the change log
https://github.com/tardyp/sphinx-jinja/blob/master/ChangeLog#L3


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@eladkal eladkal requested a review from potiuk March 8, 2022 21:22
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

Co-authored-by: Jed Cunningham <[email protected]>
@eladkal eladkal mentioned this pull request Mar 8, 2022
@eladkal
Copy link
Contributor Author

eladkal commented Mar 8, 2022

Raised also #22101 to see if we can upgrade version directly

@eladkal eladkal mentioned this pull request Mar 8, 2022
@potiuk potiuk closed this Mar 9, 2022
@potiuk
Copy link
Member

potiuk commented Mar 9, 2022

Merged #22101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants