Use entire tenant domain name in dbt Cloud connection #28890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: apache#27146 Currently users can connect to both single-tenant and multi-tenant instances of dbt Cloud. However, for the enterprise tier, there is a new region offered as well as private instance support. The existing `tenant` value does not cover the ability to modify the entire domain name which could be required for users on the enterprise plan. This enhancement allows users to specify the tenant domain they wish to connect to while keeping the "cloud.getdbt.com" domain as the default. Additionally, backward compat is implemented for those who are only specifying the third-level domain for single-tenant instances and wish to upgrade the provider version.
37 tasks
josh-fell
added a commit
to josh-fell/astronomer-providers
that referenced
this pull request
Jan 23, 2023
Related: apache/airflow#27146 apache/airflow#28890 In OSS Airflow, the dbt Cloud connection has replaced `schema` for `host` to provide the "tenant" name. This fix was included in the latest version of the dbt Cloud provider (2.3.1) and should also be reflected in this provider.
phanikumv
pushed a commit
to astronomer/astronomer-providers
that referenced
this pull request
Jan 24, 2023
Related: apache/airflow#27146 apache/airflow#28890 In OSS Airflow, the dbt Cloud connection has replaced `schema` for `host` to provide the "tenant" name. This fix was included in the latest version of the dbt Cloud provider (2.3.1) and should also be reflected in this provider.
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Feb 2, 2023
Related: apache#28890 apache#29014 There was a recent enhancement of DbtCloudRunJobOperator to include deferrable/async functionality. Unfortunately the `tenant` evaluation in the DbtCloudHook was outdated and didn't include the most recent change to properly handle domain specification. This PR consolidates the tenant eval logic to a common method to be used by both sync and async methods in the hook.
josh-fell
added a commit
that referenced
this pull request
Feb 2, 2023
* Correct tenant eval within async logic of DbtCloudHook Related: #28890 #29014 There was a recent enhancement of DbtCloudRunJobOperator to include deferrable/async functionality. Unfortunately the `tenant` evaluation in the DbtCloudHook was outdated and didn't include the most recent change to properly handle domain specification. This PR consolidates the tenant eval logic to a common method to be used by both sync and async methods in the hook. * Remove Connection.schema use * Update provider.yaml and changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #27146
Currently users can connect to both single-tenant and multi-tenant instances of dbt Cloud. However, for the enterprise tier, there is a new region offered as well as private instance support. The existing
tenantvalue does not cover the ability to modify the entire domain name which could be required for users on the enterprise plan.This enhancement allows users to specify the tenant domain they wish to connect to while keeping the "cloud.getdbt.com" domain as the default. Additionally, backward compat is implemented for those who are only specifying the third-level domain for single-tenant instances and wish to upgrade the provider version.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.