Use entire tenant domain name in dbt Cloud connection #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: apache/airflow#27146 apache/airflow#28890 In OSS Airflow, the dbt Cloud connection has replaced `schema` for `host` to provide the "tenant" name. This fix was included in the latest version of the dbt Cloud provider (2.3.1) and should also be reflected in this provider.
josh-fell
requested review from
phanikumv,
rajaths010494,
pankajastro and
pankajkoti
as code owners
josh-fell
commented
Jan 23, 2023
| if base_url and not base_url.endswith("/") and endpoint and not endpoint.startswith("/"): | ||
| url = base_url + "/" + endpoint | ||
| else: | ||
| url = (base_url or "") + (endpoint or "") |
There was a problem hiding this comment.
Removed the if/else since this line would never be executed.
Codecov ReportBase: 98.61% // Head: 98.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 98.61% 98.63% +0.02%
==========================================
Files 89 89
Lines 4970 4972 +2
==========================================
+ Hits 4901 4904 +3
+ Misses 69 68 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
If the fix here is acceptable, I can add it to OSS Airflow as well. Although there is probably some other refactoring that could be done (i.e. a shared function between the Async and sync versions). |
rajaths010494
approved these changes
Jan 24, 2023
pankajastro
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: apache/airflow#27146 apache/airflow#28890
In OSS Airflow, the dbt Cloud connection has replaced
schemaforhostto provide the "tenant" name. This fix was included in the latest version of the dbt Cloud provider (2.3.1) and should also be reflected in this provider.