Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate core EmailOperator to SMTP provider #30531

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hussein-awala
Copy link
Member

closes: #30530


In this PR, we migrate core EmailOperator to SMTP provider, and we deprecate the core one.

@hussein-awala hussein-awala force-pushed the migrate_core_email_operator branch from 895f99d to 2f93d11 Compare April 10, 2023 22:25
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 26, 2023
@hussein-awala hussein-awala removed the stale Stale PRs per the .github/workflows/stale.yml policy file label May 26, 2023

# for credentials, we use the connection if it exists, otherwise we use the config
if connection.login is None or connection.password is None:
warnings.warn(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning assumes incorrectly that it has to fallback to cfg settings to find a username or password for smtp. Not all smtp servers require authentication to send mail.

It can not be assumed that if a connection has no username or password that the connection config is wrong and thus falling back to legacy config

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Aug 8, 2023
@hussein-awala hussein-awala added pinned Protect from Stalebot auto closing and removed stale Stale PRs per the .github/workflows/stale.yml policy file labels Aug 8, 2023
@eladkal eladkal added provider:smtp pinned Protect from Stalebot auto closing area:providers and removed pinned Protect from Stalebot auto closing kind:documentation labels Aug 27, 2023
@eladkal
Copy link
Contributor

eladkal commented Aug 16, 2024

@hussein-awala i think now that main branch is Airflow 3 this PR should be easier

@eladkal
Copy link
Contributor

eladkal commented Jan 24, 2025

@hussein-awala will you have time to complete this one?

@hussein-awala
Copy link
Member Author

@hussein-awala will you have time to complete this one?

I will try to complete it by tomorrow.

@hussein-awala
Copy link
Member Author

@eladkal I think there is no need to migrate it, we can delete the resources we want to deprecate and clean the code. I created this draft: #46041.

For version 2.11, and since the provider operator and SMTP Notifer have been introduced for quite some time, we don't need to create a complicated backport, IMHO it will be enough to inform/warn users about the upcoming deprecation. WDYT?

@eladkal
Copy link
Contributor

eladkal commented Jan 25, 2025

I agree. The goal is to remove email integration from core completely

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep it?
We migrated almost all core operators to standard provider.
Should we just remove this file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers pinned Protect from Stalebot auto closing provider:smtp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate core EmailOperator to SMTP provider
3 participants