-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional from_email parameter to EmailOperator #33288
Add optional from_email parameter to EmailOperator #33288
Conversation
Related to #33287 |
also related to #30531 cc: @hussein-awala |
Have you considered adding test cases to verify the new behavior? |
You are right. Let me update the test to check whether this field is passed to backend. |
I have updated the test for verifying new from_email parameter. |
@potiuk , would you be able to approve the test workflow for latest commit. Need to re-run the tests as I have email test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm setting PR to request changes to avoid merge.
Needs to wait for @hussein-awala review as he is working on refactoring this operator into the smtp provider.
(This is technical step not to worry)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Will this get merged to main? |
@hussein-awala , Can you please review this and check if this PR can be merged? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
@hussein-awala , Did you get a chance to review this PR? |
Look like the Airflow team isn't interested in this feature. Hence closing this PR. |
closes: #33287
Add optional from_email parameter to EmailOperator which allows users to provide sender emails in Dags.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.