Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional from_email parameter to EmailOperator #33288

Conversation

shakeelansari63
Copy link

@shakeelansari63 shakeelansari63 commented Aug 10, 2023

closes: #33287

Add optional from_email parameter to EmailOperator which allows users to provide sender emails in Dags.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Aug 10, 2023
@shakeelansari63
Copy link
Author

Related to #33287

@potiuk
Copy link
Member

potiuk commented Aug 10, 2023

also related to #30531 cc: @hussein-awala

@vijayasarathib
Copy link
Contributor

Have you considered adding test cases to verify the new behavior?

@shakeelansari63
Copy link
Author

shakeelansari63 commented Aug 10, 2023

Have you considered adding test cases to verify the new behavior?

You are right. Let me update the test to check whether this field is passed to backend.

@shakeelansari63
Copy link
Author

I have updated the test for verifying new from_email parameter.

@shakeelansari63
Copy link
Author

@potiuk , would you be able to approve the test workflow for latest commit. Need to re-run the tests as I have email test.

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm setting PR to request changes to avoid merge.
Needs to wait for @hussein-awala review as he is working on refactoring this operator into the smtp provider.

(This is technical step not to worry)

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 25, 2023
@Franz1241
Copy link

Will this get merged to main?

@shakeelansari63
Copy link
Author

@hussein-awala , Can you please review this and check if this PR can be merged?

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 26, 2023
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 10, 2023
@github-actions github-actions bot closed this Nov 15, 2023
@potiuk potiuk reopened this Apr 16, 2024
@eladkal eladkal removed the stale Stale PRs per the .github/workflows/stale.yml policy file label May 1, 2024
@shakeelansari63
Copy link
Author

@hussein-awala , Did you get a chance to review this PR?

@Taragolis Taragolis requested a review from hussein-awala May 3, 2024 08:01
@shakeelansari63 shakeelansari63 requested a review from eladkal June 5, 2024 10:02
@shakeelansari63
Copy link
Author

Look like the Airflow team isn't interested in this feature. Hence closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add from_email parameter to EmailOperator
5 participants