Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some errant strings in the kafka example dags #30818

Merged
merged 5 commits into from
Apr 22, 2023
Merged

fixed some errant strings in the kafka example dags #30818

merged 5 commits into from
Apr 22, 2023

Conversation

dylanbstorey
Copy link
Contributor

Updates to the system tests / example dags for the Apache Kafka provider so that they are functional and useful w/o needing manual intervention when testing for releases.

@potiuk
Copy link
Member

potiuk commented Apr 22, 2023

FYI. @dylanbstorey - speaking of static checks:

pre-commit install

And let fixes be applied while commiting or (and)

breeze static-checks --last-commit

(after squashing all your commits to one)

Those help with automatically fixing stuff before CI complains :).

And yeah, there are cases it does not work when rebasing and things, but usually it does.

@potiuk potiuk merged commit 424fc17 into apache:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants