Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some errant strings in the kafka example dags #30818

Merged
merged 5 commits into from
Apr 22, 2023
+117 −101
Merged

fixed some errant strings in the kafka example dags #30818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4773a32
fixed some errant strings in the kafka example dags
dylanbstorey Apr 22, 2023
b66b844
fixed some errant strings in the kafka example dags
dylanbstorey Apr 22, 2023
17c266e
Merge branch 'fix/kafka-example-dags' of github.com:dylanbstorey/airf…
dylanbstorey Apr 22, 2023
b8e97eb
Merge branch 'fix/kafka-example-dags' of github.com:dylanbstorey/airf…
dylanbstorey Apr 22, 2023
5c7c7e0
Merge branch 'fix/kafka-example-dags' of github.com:dylanbstorey/airf…
dylanbstorey Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 37 additions & 23 deletions tests/system/providers/apache/kafka/example_dag_event_listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,31 +26,41 @@

from airflow import DAG

# Connections needed for this example dag to finish
from airflow.models import Connection

# This is just for setting up connections in the demo - you should use standard
# methods for setting these connections in production
from airflow.operators.python import PythonOperator
from airflow.operators.trigger_dagrun import TriggerDagRunOperator
from airflow.providers.apache.kafka.operators.produce import ProduceToTopicOperator
from airflow.providers.apache.kafka.sensors.kafka import AwaitMessageTriggerFunctionSensor
from airflow.utils import db

# Connections needed for this example dag to finish
# from airflow.models import Connection
# from airflow.utils import db
#
# db.merge_conn(
# Connection(
# conn_id="fizz_buzz",
# conn_type="kafka",
# extra=json.dumps(
# {
# "bootstrap.servers": "broker:29092",
# "group.id": "fizz_buzz",
# "enable.auto.commit": False,
# "auto.offset.reset": "beginning",
# }
# ),
# )
# )

def load_connections():
db.merge_conn(
Connection(
conn_id="fizz_buzz_1",
conn_type="kafka",
extra=json.dumps({"socket.timeout.ms": 10, "bootstrap.servers": "broker:29092"}),
)
)

db.merge_conn(
Connection(
conn_id="fizz_buzz_2",
conn_type="kafka",
extra=json.dumps(
{
"bootstrap.servers": "broker:29092",
"group.id": "fizz_buzz",
"enable.auto.commit": False,
"auto.offset.reset": "beginning",
}
),
)
)


def _producer_function():
Expand All @@ -71,8 +81,10 @@ def _generate_uuid():
tags=["fizz-buzz"],
) as dag:

t0 = PythonOperator(task_id="load_connections", python_callable=load_connections)

t1 = ProduceToTopicOperator(
kafka_config_id="fizz_buzz",
kafka_config_id="fizz_buzz_1",
task_id="produce_to_topic",
topic="fizz_buzz",
producer_function=_producer_function,
Expand All @@ -97,25 +109,27 @@ def await_function(message):
def pick_downstream_dag(message, **context):
if message % 15 == 0:
print(f"encountered {message} - executing external dag!")
TriggerDagRunOperator(trigger_dag_id="fizz_buzz", task_id=f"{message}{_generate_uuid()}").execute(
TriggerDagRunOperator(trigger_dag_id="fizz-buzz", task_id=f"{message}{_generate_uuid()}").execute(
context
)
else:
if message % 3 == 0:
print(f"encountered {message} FIZZ !")
if message & 5 == 0:
if message % 5 == 0:
print(f"encountered {message} BUZZ !")

# [START howto_sensor_await_message_trigger_function]
listen_for_message = AwaitMessageTriggerFunctionSensor(
kafka_config_id="fizz_buzz",
kafka_config_id="fizz_buzz_2",
task_id="listen_for_message",
topics=["fizz_buzz"],
apply_function="event_listener.await_function",
apply_function="example_dag_event_listener.await_function",
event_triggered_function=pick_downstream_dag,
)
# [END howto_sensor_await_message_trigger_function]

t0 >> t1

with DAG(
dag_id="fizz-buzz",
description="Triggered when mod 15 is 0.",
Expand Down
158 changes: 80 additions & 78 deletions tests/system/providers/apache/kafka/example_dag_hello_kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,79 +30,6 @@
from airflow.providers.apache.kafka.operators.produce import ProduceToTopicOperator
from airflow.providers.apache.kafka.sensors.kafka import AwaitMessageSensor

# Connections needed for this example dag to finish
# from airflow.models import Connection
# from airflow.utils import db
# db.merge_conn(
# Connection(
# conn_id="t1-3",
# conn_type="kafka",
# extra=json.dumps({"socket.timeout.ms": 10, "bootstrap.servers": "broker:29092"}),
# )
# )

# db.merge_conn(
# Connection(
# conn_id="t2",
# conn_type="kafka",
# extra=json.dumps(
# {
# "bootstrap.servers": "broker:29092",
# "group.id": "t2",
# "enable.auto.commit": False,
# "auto.offset.reset": "beginning",
# }
# ),
# )
# )

# db.merge_conn(
# Connection(
# conn_id="t4",
# conn_type="kafka",
# extra=json.dumps(
# {
# "bootstrap.servers": "broker:29092",
# "group.id": "t4",
# "enable.auto.commit": False,
# "auto.offset.reset": "beginning",
# }
# ),
# )
# )

# db.merge_conn(
# Connection(
# conn_id="t4b",
# conn_type="kafka",
# extra=json.dumps(
# {
# "bootstrap.servers": "broker:29092",
# "group.id": "t4b",
# "enable.auto.commit": False,
# "auto.offset.reset": "beginning",
# }
# ),
# )
# )


# db.merge_conn(
# Connection(
# conn_id="t5",
# conn_type="kafka",
# extra=json.dumps(
# {
# "bootstrap.servers": "broker:29092",
# "group.id": "t5",
# "enable.auto.commit": False,
# "auto.offset.reset": "beginning",
# }
# ),
# )
# )


default_args = {
"owner": "airflow",
"depend_on_past": False,
Expand All @@ -113,6 +40,80 @@
}


def load_connections():
# Connections needed for this example dag to finish
from airflow.models import Connection
from airflow.utils import db

db.merge_conn(
Connection(
conn_id="t1-3",
conn_type="kafka",
extra=json.dumps({"socket.timeout.ms": 10, "bootstrap.servers": "broker:29092"}),
)
)

db.merge_conn(
Connection(
conn_id="t2",
conn_type="kafka",
extra=json.dumps(
{
"bootstrap.servers": "broker:29092",
"group.id": "t2",
"enable.auto.commit": False,
"auto.offset.reset": "beginning",
}
),
)
)

db.merge_conn(
Connection(
conn_id="t4",
conn_type="kafka",
extra=json.dumps(
{
"bootstrap.servers": "broker:29092",
"group.id": "t4",
"enable.auto.commit": False,
"auto.offset.reset": "beginning",
}
),
)
)

db.merge_conn(
Connection(
conn_id="t4b",
conn_type="kafka",
extra=json.dumps(
{
"bootstrap.servers": "broker:29092",
"group.id": "t4b",
"enable.auto.commit": False,
"auto.offset.reset": "beginning",
}
),
)
)

db.merge_conn(
Connection(
conn_id="t5",
conn_type="kafka",
extra=json.dumps(
{
"bootstrap.servers": "broker:29092",
"group.id": "t5",
"enable.auto.commit": False,
"auto.offset.reset": "beginning",
}
),
)
)


def producer_function():
for i in range(20):
yield (json.dumps(i), json.dumps(i + 1))
Expand Down Expand Up @@ -155,13 +156,14 @@ def hello_kafka():
catchup=False,
tags=["example"],
) as dag:
t0 = PythonOperator(task_id="load_connections", python_callable=load_connections)

# [START howto_operator_produce_to_topic]
t1 = ProduceToTopicOperator(
kafka_config_id="t1-3",
task_id="produce_to_topic",
topic="test_1",
producer_function="hello_kafka.producer_function",
producer_function="example_dag_hello_kafka.producer_function",
)
# [END howto_operator_produce_to_topic]

Expand All @@ -173,7 +175,7 @@ def hello_kafka():
kafka_config_id="t2",
task_id="consume_from_topic",
topics=["test_1"],
apply_function="hello_kafka.consumer_function",
apply_function="example_dag_hello_kafka.consumer_function",
apply_function_kwargs={"prefix": "consumed:::"},
commit_cadence="end_of_batch",
max_messages=10,
Expand Down Expand Up @@ -222,7 +224,7 @@ def hello_kafka():
kafka_config_id="t5",
task_id="awaiting_message",
topics=["test_1"],
apply_function="hello_kafka.await_function",
apply_function="example_dag_hello_kafka.await_function",
xcom_push_key="retrieved_message",
)
# [END howto_sensor_await_message]
Expand All @@ -234,8 +236,8 @@ def hello_kafka():

t6.doc_md = "The task that is executed after the deferable task returns for execution."

t1 >> t2
t3 >> [t4, t4b] >> t5 >> t6
t0 >> t1 >> t2
t0 >> t3 >> [t4, t4b] >> t5 >> t6


from tests.system.utils import get_test_run # noqa: E402
Expand Down