Fix logic of the skip_all_except method #31153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhigimont
force-pushed
the
fix_branch_operator_for_mapped_tasks
branch
2 times, most recently
from
473d6bd to
9bfe60c
Compare
uranusjr
reviewed
May 9, 2023
dzhigimont
force-pushed
the
fix_branch_operator_for_mapped_tasks
branch
2 times, most recently
from
e59e648 to
949733e
Compare
uranusjr
reviewed
May 12, 2023
|
Also a test on the bug this should fix would be preferred. |
dzhigimont
force-pushed
the
fix_branch_operator_for_mapped_tasks
branch
from
949733e to
33ef635
Compare
I've added the appropriate test case |
dzhigimont
force-pushed
the
fix_branch_operator_for_mapped_tasks
branch
2 times, most recently
from
86b4176 to
a6f7a83
Compare
dzhigimont
force-pushed
the
fix_branch_operator_for_mapped_tasks
branch
from
a6f7a83 to
73bc921
Compare
uranusjr
reviewed
Jun 13, 2023
uranusjr
reviewed
Jun 13, 2023
dzhigimont
force-pushed
the
fix_branch_operator_for_mapped_tasks
branch
from
e79ceaa to
aaa1bb9
Compare
uranusjr
reviewed
Jun 14, 2023
uranusjr
approved these changes
Jun 14, 2023
|
rebasing after #32405 is merged should solve the failing test |
potiuk
force-pushed
the
fix_branch_operator_for_mapped_tasks
branch
from
8543f62 to
2888976
Compare
eladkal
approved these changes
Jul 6, 2023
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix logic of the skip_all_except method to work correctly with a mapped branch operator.
Closes: #30883