Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing main due to new release of jsonschema #32405

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix failing main due to new release of jsonschema #32405

merged 1 commit into from
Jul 6, 2023

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Jul 6, 2023 •
edited
Loading

Verify provider tests fail on #31153 with

Unknown warnings generated:

/usr/local/lib/python3.8/site-packages/nbformat/json_compat.py:14:Importing ErrorTree directly from the jsonschema package is deprecated and will become an ImportError. Import it from jsonschema.exceptions instead.
/usr/local/lib/python3.8/site-packages/nbformat/json_compat.py:14:Importing ErrorTree directly from the jsonschema package is deprecated and will become an ImportError. Import it from jsonschema.exceptions instead.

ERROR! There were 2 warnings generated during the import

https://github.com/apache/airflow/actions/runs/5475391627/jobs/9972903745?pr=31153#step:11:1631

Due to new release of jsonschema

We are affected since we are using nbformat lib.
I raised PR to nbformat jupyter/nbformat#368 to handle it.

In the mean time unblocking main by adding the warning to KNOWN_COMMON_DEPRECATED_MESSAGES

@eladkal eladkal requested review from potiuk and ashb as code owners July 6, 2023 14:14
@eladkal eladkal mentioned this pull request Jul 6, 2023
Merged
amoghrajesh
amoghrajesh approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
Copy link
Member

potiuk commented Jul 6, 2023

Merging, the provider validation is OK. The failure is just hob failing

@potiuk potiuk merged commit 89d5e8b into apache:main Jul 6, 2023
@potiuk
Copy link
Member

potiuk commented Jul 6, 2023

BTW. I think we should re-think those warning checks. There is very little value in having those I think

@eladkal eladkal deleted the warn branch July 6, 2023 14:44
ephraimbuddy pushed a commit that referenced this pull request Jul 6, 2023
@eladkal @ephraimbuddy
Fix failing main due to new release of jsonschema (#32405)
fc61875 
(cherry picked from commit 89d5e8b)
@ephraimbuddy ephraimbuddy added this to the Airflow 2.6.3 milestone Jul 7, 2023
@ephraimbuddy ephraimbuddy mentioned this pull request Jul 7, 2023
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@amoghrajesh amoghrajesh amoghrajesh approved these changes

@phanikumv phanikumv phanikumv approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees
No one assigned
Labels
area:dev-tools
Projects
None yet
Milestone
Airflow 2.6.3
Development

Successfully merging this pull request may close these issues.
6 participants
@eladkal @potiuk @hussein-awala @amoghrajesh @phanikumv @ephraimbuddy