Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix hardcoded BigQuery to GCS project id #32143

Closed
wants to merge 4 commits into from

Conversation

irvifa
Copy link

@irvifa irvifa commented Jun 26, 2023

In the airflow configuration, we defined the self.project_id where we pass the information regarding the project_id where we run the job. There's another configuration that is defined in _prepare_configuration regarding how we define the job id given for the BQ table source.

closes: #32106
related: #32106


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

In the airflow configuration, we defined the self.project_id where we
pass the information regarding the project_id where we run the job.
There's other configuration which is defined in _prepare_configuration
regarding how we define the job id given for the BQ table source.
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 26, 2023
@potiuk
Copy link
Member

potiuk commented Jun 27, 2023

@Yaro1 - What do you think about this change ? Your change from hook.project_id from #30053 seems to be now reverting somehow

@irvifa and @Yaro1 -> maybe you can discuss which is the best approach?

@eladkal
Copy link
Contributor

eladkal commented Jul 6, 2023

Closed in favor of #32232

@eladkal eladkal closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCSToBigQueryOperator and BigQueryToGCSOperator do not respect their project_id arguments
3 participants