-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BigQuery transfer operators to respect project_id arguments #32232
Fix BigQuery transfer operators to respect project_id arguments #32232
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
LGTM. Is it possible to add test ? and @Yaro1 -> are you ok with it? |
Static checks need fixing + rebase. |
Lets please fix all occurrences as mentioned in #32106 (comment) |
@eladkal Sure, that makes sense. Working on merging all the fixes into this PR. |
…s project_id is the only fallback if table project is not specified.
Tests are failing. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Congrats on this, and my thanks! |
Yes, many thanks from my side too! |
While submitting the BigQuery to GCS job or GCS to BigQuery job, the current code only prefers the project_id of the BigQuery table, and ignores the provided project_id argument to the
BigQueryToGCSOperator
andGCSToBigQueryOperator
operators (as pointed out by @bhagany in #32106). This is not the expected behaviour, and the provided project_id must be used to submit the job to BigQuery and use that project's resources for computation.This change aims to correct this behaviour by making hook's project_id as the fallback project for both BigQuery storage and compute.
Note: This change replaces @Yaro1 's previous change in #30053, where the BQ table's project_id is used for computation.
closes: #32106
suppress: #32144
suppress: #32143
suppress: #32095