Rework provider manager to treat Airflow core hooks like other provider hooks #33051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:CLI
area:core-operators
|
Nice one. It's almost the last thing for connections - the last one is #32048 |
potiuk
approved these changes
Aug 6, 2023
|
And yes - we sholuld drop mesos - in separate PR. |
jscheffl
deleted the
feature/rework-provider-manager-for-airflow-core-hooks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the ground-work to a follow-up PR #33017
I realized that the providers-manager is implemented inconsistently and treats core hooks other than provider contributed hooks. Core hooks are not providing extended web UI fields (feature is ignored) as well as the list of provided generic hooks is redundant in CLI and UI code.
This PR cleans this up and:
Point of discussion would be if we still should further carry the generic hook type "Mesos Framework ID" which seems to be a legacy leftover from Airflow 1.x. This was a former executor type but the code is gone completely since Airflow 2.0 and besides the traces in code I could find no reference. I assume nobody is using this anymore.
How to test: