Remove leftover mesos reference in generic hooks #35232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Oct 28, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up of #33051 where I realized that some "mesos" leftovers are in the code, this is a cleanup-PR, It removes the generic connection in Airflow core that provides a "Mesos Framework ID".
I crawled through the code back into history of Airflow 1.10 to find where it comes from. In Airflow 1.10 there was formerly a mesos executor supported which all had been treated as legacy and was removed when going to Airflow 2.0. Just a generic connection hook was left. Also I could not find any traces somewhere in code or documentation where it is still used. But as no mesos executor exists anymore and even the Spark provider only uses a direct URL as parameters this is really a leftover.
As it is not providing any benefit and preventing that somebody in the future need to crawl into history, I propose to remove it. It is not breaking because if somebody really is still using it, it will fall-back in the UI to "generic" and technically is still usable.