-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing re2 dependency to cncf.kubernetes and celery providers #33237
Conversation
Should we update the precommit check to cover providers now as well? |
Good point . I will add it as a separate PR. |
+1, but should be implemented in a separate PR as @potiuk suggested. |
Waits for this one to be merged in #33240 |
cc: @eladkal - for me sounds like a good reason to release celery and kubernetes provider soon(ish). |
For providers that are using google-re2 it should be declared as dependency. Follow up after apache#33237
For providers that are using google-re2 it should be declared as dependency. Follow up after #33237
Thanks for the fix, I missed that |
We all did :) |
re lib was replaced by re2 in Airflow core and Kubernetes (#32303), and the dependency was added only to Airflow setup (#32060). However, when we install the Kubernetes provider with an old version of Airflow, the provider will be broken because the re2 is not installed automatically, and we need to add it explicitly:
I think we'll have the same problem with celery provider when we want to use the new executor with the old Airflow versions (>=2.4.0, <2.7.0).
This PR add
google-re2
dependency to cncf.kubernetes and celery providers.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.