Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if google-re2 is declared as dependency #33240

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 8, 2023

For providers that are using google-re2 it should be declared as dependency. Follow up after #33237


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Aug 8, 2023

Screenshot 2023-08-09 at 01 10 30

@potiuk
Copy link
Member Author

potiuk commented Aug 8, 2023

It will fail until #33237 is merged and I rebase :)

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

@potiuk potiuk force-pushed the add-check-for-google-re2-dependency branch from 403bcfd to 4e4e278 Compare August 8, 2023 23:24
@potiuk
Copy link
Member Author

potiuk commented Aug 8, 2023

Applied. simpler, less nesting, faster

@potiuk potiuk force-pushed the add-check-for-google-re2-dependency branch from 4e4e278 to 8ef78a1 Compare August 8, 2023 23:26
@potiuk potiuk force-pushed the add-check-for-google-re2-dependency branch from 8ef78a1 to 544843c Compare August 8, 2023 23:45
For providers that are using google-re2 it should be declared as
dependency. Follow up after apache#33237
@potiuk potiuk force-pushed the add-check-for-google-re2-dependency branch from 544843c to 1b80d44 Compare August 9, 2023 00:23
@potiuk potiuk merged commit c7e6914 into apache:main Aug 9, 2023
@potiuk potiuk deleted the add-check-for-google-re2-dependency branch August 9, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants