-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MessageDeduplicationId support to AWS SqsPublishOperator #45051
Add MessageDeduplicationId support to AWS SqsPublishOperator #45051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs also a test for the success scenario.
You can add the needed changes to test_execute_success
or write a separated test if needed
Done! |
@eladkal ? |
3b5918b
to
860b6ea
Compare
…45051) * add MessageDeduplicationId support to AWS SqsPublishOperator * modified test --------- Co-authored-by: pratiksha rajendrabhai badheka <pratiksha@DESKTOP-T5HUA05>
…45051) * add MessageDeduplicationId support to AWS SqsPublishOperator * modified test --------- Co-authored-by: pratiksha rajendrabhai badheka <pratiksha@DESKTOP-T5HUA05>
…45051) * add MessageDeduplicationId support to AWS SqsPublishOperator * modified test --------- Co-authored-by: pratiksha rajendrabhai badheka <pratiksha@DESKTOP-T5HUA05>
Closes : #44876
Currently, the
SqsPublishOperator
in Airflow does not support theMessageDeduplicationId
parameter for deduplication of messages sent to AWS SQS FIFO queues. Users are forced to rely solely onContentBasedDeduplication
, which may not be suitable for all scenarios.This PR aims to add support for
MessageDeduplicationId
and test for deduplication to provide more flexibility and control over message deduplication.(https://boto3.amazonaws.com/v1/documentation/api/1.35.6/reference/services/sqs/client/send_message.html))
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.