Remove tuple_in_condition helpers #45201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun,
jscheffl and
XD-DENG
as code owners
boring-cyborg
bot
added
area:providers
area:Scheduler
eladkal
approved these changes
Dec 25, 2024
jscheffl
approved these changes
Dec 25, 2024
pierrejeambrun
approved these changes
Dec 25, 2024
These were introduced when not all databases support the tuple expression. Now that sqlalchemy.tuple_ is supported in all database backends Airflow officially support, they are not needed anymore. We actually already use the tuple_ expression directly in a lot of code right now. The not_in variant is removed outright. The in_ variant is kept for now since it was used in the standard provider. It is therefore kept for now (but not used anywhere), and will be removed in a future release.
uranusjr
force-pushed
the
remove-tuple-helpers
branch
from
8ea1bcb to
1ecb0a1
Compare
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 6, 2025
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were introduced when not all databases support the tuple expression. Now that sqlalchemy.tuple_ is supported in all database backends Airflow officially support, they are not needed anymore.
We actually already use the tuple_ expression directly in a lot of code right now.
The not_in variant is removed outright. The in_ variant is kept for now since it was used in the standard provider. It is therefore kept for now (but not used anywhere), and will be removed in a future release.