-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DockerSwarmOperator auto_remove to align with DockerOperator #45745
Update DockerSwarmOperator auto_remove to align with DockerOperator #45745
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
providers/src/airflow/providers/docker/operators/docker_swarm.py
Outdated
Show resolved
Hide resolved
4b74edf
to
1f83742
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be possible for us to add a unit test for it so that we won't make the same mistake in the future. Thanks!
e74f315
to
497813f
Compare
7187d1d
to
518dab1
Compare
518dab1
to
d098d21
Compare
sorry for the review request mess... |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…pache#45745) * Update DockerSwarmOperator auto_remove to align with DockerOperator * add docker swarm auto remove test
The description of the auto_remove field didn't match the field types defined in DockerOperator.
Also "success" and "force" currently don't behave as expected.