Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DockerSwarmOperator auto_remove to align with DockerOperator #45745

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

niklasr22
Copy link
Contributor

The description of the auto_remove field didn't match the field types defined in DockerOperator.
Also "success" and "force" currently don't behave as expected.


Copy link

boring-cyborg bot commented Jan 17, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@niklasr22 niklasr22 force-pushed the fix-docker-swarm-operator-auto-remove branch from 4b74edf to 1f83742 Compare February 2, 2025 10:05
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible for us to add a unit test for it so that we won't make the same mistake in the future. Thanks!

@niklasr22 niklasr22 force-pushed the fix-docker-swarm-operator-auto-remove branch 2 times, most recently from e74f315 to 497813f Compare February 8, 2025 15:04
@niklasr22 niklasr22 force-pushed the fix-docker-swarm-operator-auto-remove branch 2 times, most recently from 7187d1d to 518dab1 Compare February 8, 2025 15:17
@niklasr22 niklasr22 force-pushed the fix-docker-swarm-operator-auto-remove branch from 518dab1 to d098d21 Compare February 8, 2025 15:18
@niklasr22
Copy link
Contributor Author

sorry for the review request mess...

@niklasr22 niklasr22 requested a review from Lee-W February 8, 2025 15:29
@Lee-W Lee-W merged commit 9c833bf into apache:main Feb 10, 2025
61 checks passed
Copy link

boring-cyborg bot commented Feb 10, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
…pache#45745)

* Update DockerSwarmOperator auto_remove to align with DockerOperator

* add docker swarm auto remove test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants