-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum dependencies for apache-beam deps on Py 3.12+3.13 #46321
Conversation
Cool ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it will work, aligning with the last fix for beam
Odd, that didn't seem to work:
|
I'm going to set the min version of apache-beam itself instead. |
Ah. This is because apache-beam 2.55.0 has grpcio.tools as "build requirements" not "requirements". In a modern build packaging - when a frontend is building package (because it does not have corresponding binary wheel) it will perform the build of that package from .sdist in "isolated build environment" -> where it downloads and sets up temporary venv with the dependencies specified in the "build requirements" of that package. From the error looks like apache-beam 2.55.0 has grpcio-tools 1.53.0 set as their |
So yeah - we should limit |
b80fcac
to
488e9db
Compare
Older versions of apache-beam package depend upon gprcio-tools, but the version requirement they specify doesn't work on Py 3.12, but the metadata doesn't say that, so it tries to compile it and fails.
488e9db
to
91ef55a
Compare
Older versions of apache-beam package depend upon gprcio-tools, but the version requirement they specify doesn't work on Py 3.12, but the metadata doesn't say that, so it tries to compile it and fails. This updates the min version to the min supported version with wheels for 3.12
Older versions of apache-beam package depend upon gprcio-tools, but the version requirement they specify doesn't work on Py 3.12, but the metadata doesn't say that, so it tries to compile it and fails. This updates the min version to the min supported version with wheels for 3.12
Older versions of apache-beam package depend upon gprcio-tools, but the version requirement they specify doesn't work on Py 3.12, but the metadata doesn't say that, so it tries to compile it and fails. This updates the min version to the min supported version with wheels for 3.12
Older versions of apache-beam package depend upon gprcio-tools, but the version requirement they specify doesn't work on Py 3.12, but the metadata doesn't say that, so it tries to compile it and fails. This updates the min version to the min supported version with wheels for 3.12
Older versions of apache-beam package depend upon gprcio-tools, but the version requirement they specify doesn't work on Py 3.12, but the metadata doesn't say that, so it tries to compile it and fails. This updates the min version to the min supported version with wheels for 3.12
Older versions of apache-beam package depend upon gprcio-tools, but the version requirement they specify doesn't work on Py 3.12, but the metadata doesn't say that, so it tries to compile it and fails. This updates the min version to the min supported version with wheels for 3.12
Set minimum dependencies for apache-beam on Py 3.12+3.13
Older versions of apache-beam package depend upon gprcio-tools, but the
version requirement they specify doesn't work on Py 3.12, but the metadata
doesn't say that, so it tries to compile it and fails.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.