-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-72: Move Secrets Masker to task SDK #46375
AIP-72: Move Secrets Masker to task SDK #46375
Conversation
@eladkal / @Lee-W would this require a newsfragment? SecretsMasker was always a public interface and some users would have some custom operators would probably have used it for their redaction reasons / anything or that sort. That would mean that they might have to rewrite these operators atleast for the imports. |
Yes, it would be categorized as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does put a hard dep on Task SDK for various things in the scheduler/code that we might want to split out later, but that exists for now anyway and not duplicating the code is better.
8735fed
to
dde6603
Compare
@Lee-W I added a newsfragment for this, does it look OK only with respect to that? |
Co-authored-by: Wei Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the newsfragment looks good to me 👍
Thanks for the reviews, merging it |
This reverts commit e78b5b4.
closes: #45438
Moving the secrets masker class to task sdk so that it can be used to write dags and tasks, in form of custom operators
TODO:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.