Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support docker operator arg labels #46643

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

phi-friday
Copy link
Contributor

The docker cli client supports the labels variable. Adding this is simple, and will be useful.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@potiuk potiuk merged commit 2bf9897 into apache:main Feb 12, 2025
61 checks passed
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
* feat: add args labels

* fix: add larg labels stub

* test: add labels test

* fix: assert_called_once_with error

* fix: create_container.assert_* error

* fix: rm create_host_config labels
@phi-friday phi-friday deleted the feat-docker-label branch February 22, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants