Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system test example_dms_serverless #46684

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

vincbeck
Copy link
Contributor

Update the system test example_dms_serverless to remove unnecessary code in the DAG. I also made some updates on the waiter that are necessary not only for the system test but as a general use.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:amazon AWS/Amazon - related issues label Feb 12, 2025
@vincbeck vincbeck force-pushed the vincbeck/dms_serverless_sys_test branch from e6a60e9 to bdc8114 Compare February 12, 2025 15:57
@vincbeck vincbeck force-pushed the vincbeck/dms_serverless_sys_test branch from bdc8114 to 5e08bef Compare February 12, 2025 16:28
…ation_terminal_status` to include `created` and `deprovisioned` states
@vincbeck vincbeck force-pushed the vincbeck/dms_serverless_sys_test branch from 5e08bef to 625b410 Compare February 12, 2025 17:22
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major cleanup, including a couple of nice catches. Nice work.

FWIW, I also agree with the discussion above that it should be considered a bugfix, and the changelog addition was a good idea.

@vincbeck
Copy link
Contributor Author

Failures are unrelated to the PR and a fix is available in #46700

@vincbeck vincbeck merged commit a41a470 into apache:main Feb 12, 2025
57 of 62 checks passed
@vincbeck vincbeck deleted the vincbeck/dms_serverless_sys_test branch February 12, 2025 21:12
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants