-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update system test example_dms_serverless
#46684
Merged
vincbeck
merged 4 commits into
apache:main
from
aws-mwaa:vincbeck/dms_serverless_sys_test
Feb 12, 2025
Merged
Update system test example_dms_serverless
#46684
vincbeck
merged 4 commits into
apache:main
from
aws-mwaa:vincbeck/dms_serverless_sys_test
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6a60e9
to
bdc8114
Compare
eladkal
reviewed
Feb 12, 2025
bdc8114
to
5e08bef
Compare
…ation_terminal_status` to include `created` and `deprovisioned` states
5e08bef
to
625b410
Compare
o-nikolas
approved these changes
Feb 12, 2025
ferruzzi
reviewed
Feb 12, 2025
ferruzzi
reviewed
Feb 12, 2025
Co-authored-by: D. Ferruzzi <[email protected]>
ferruzzi
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major cleanup, including a couple of nice catches. Nice work.
FWIW, I also agree with the discussion above that it should be considered a bugfix, and the changelog addition was a good idea.
Failures are unrelated to the PR and a fix is available in #46700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the system test
example_dms_serverless
to remove unnecessary code in the DAG. I also made some updates on the waiter that are necessary not only for the system test but as a general use.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.