pass error for on_task_instance_failed in task sdk #46941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mobuchowski
force-pushed
the
fix-error-dags
branch
from
2bf994a to
5dace8b
Compare
amoghrajesh
approved these changes
Feb 21, 2025
Signed-off-by: Maciej Obuchowski <[email protected]>
mobuchowski
force-pushed
the
fix-error-dags
branch
from
5dace8b to
abcd6d1
Compare
|
Hey @mobuchowski, I am making this change #46961, I dont think it should impact, but can you check to be sure? |
|
@amoghrajesh those look orthogonal to me 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use
run_afterto generate OL run ids.This fixes #46915