-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding warning message when running APISIX in root path #1201
Conversation
You are so cool, submit a PR so soon |
BTW, if the current user is a root user, we need to add we can add it here: |
Will do. Thanks. |
we can not run APISIX with |
Then shall I exit the program if it is a root user? by checking with the |
I don't think so, user should check the permission issue by themself. There may be other users and user groups, which is difficult for us to deal with. |
When the user tries to run APISIX at I should allow users to use the |
i agree with you. some developer maybe like run apisix with root user. we need to keep it open and remind them at the right time |
APISIX Should not care system Permissions Issues,and APISIX also handle is
not good; this is the job of OS
coolsoul <[email protected]>于2020年3月7日 周六上午9:33写道:
we can not run APISIX with user root, which is not safe.
When the user tries to run APISIX at /root, he can be sure that he is a
developer, and we have printed a warning message for this case.
I should allow users to use the / root directory as a temporary
development directory.
i agree with you. some developer maybe like run apisix with root user. we
need to keep it open and remind them at the right time
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1201>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZBK2UM7GWOZ5E5MC5HFTRGGP65ANCNFSM4LBF6OKQ>
.
--
Thanks,
Ming Wen
Twitter: _WenMing
|
@membphis I have fixed the violation for Lua 5.3 and updated the nginx conf with root configurations. |
@@ -82,7 +87,9 @@ local ngx_tpl = [=[ | |||
# This is a read-only file, do not try to modify it. | |||
|
|||
master_process on; | |||
|
|||
{% if is_root_path then %} | |||
user root; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using root
as the user is dangerous and is likely to be exploited by hackers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okays, but it won't start when in root dir rite?, I guess from the previous message I understood to allow the user to start but only print warnings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right:)
IMO, We can print warnings, but we don't need to deal with the permission problem, and we don't need to be compatible with the situation of using root to start Apache APISIX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, then ill remove the root user configs, and only settle to printing warnings.
Hi all, I have accidentally deleted my fork :( , I will raise another PR with the requested changes. |
Fix #1196