Adding warning message when running APISIX in root path #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonming
approved these changes
Mar 13, 2020
membphis
reviewed
Mar 15, 2020
| local script_path = arg[0] | ||
| if script_path:sub(1, 2) == './' then | ||
| apisix_home = trim(excute_cmd("pwd")) | ||
| if not apisix_home then | ||
| error("failed to fetch current path") | ||
| end | ||
|
|
||
| if string.match(apisix_home, '^/[root][^/]+') then |
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #1201 and fix for #1196.
Based on the discussion on #1201, the PR only prints the warning message to the user and does not add the root configs to the nginx config