-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print the 'FixedSizeBinaryArray' like a normal 'BinaryArray' #1097
Print the 'FixedSizeBinaryArray' like a normal 'BinaryArray' #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @GrandChaman -- also for the test ❤️
The tests are failing due to an unrelated reason -- see #1102 -- will resolve them and get back to this |
…ay_pretty_printing
FYI @GrandChaman I have merged |
I also pushed a fix for rust fmt: 39e8326 |
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 168 168
Lines 49420 49421 +1
=======================================
+ Hits 40681 40683 +2
+ Misses 8739 8738 -1
Continue to review full report at Codecov.
|
Thanks again @GrandChaman |
Which issue does this PR close?
Closes #1096.
Rationale for this change
See #1096.
What changes are included in this PR?
A new match arm has been added to the
array_value_to_string
function to allow pretty printingFixedSizeBinaryArray
.Are there any user-facing changes?
Not directly.