Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proc-macro2 dependency to be flexible in arrow-flight #1102

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 28, 2021

Which issue does this PR close?

Resolves #1101

Rationale for this change

Hard pinning the version means fixes that require updates to the proc-macro2 library are not possible

Specifically this also fixes this breakage with thequote 1.11.0 release

cd /Users/alamb/Software/arrow-rs && CARGO_TARGET_DIR=/Users/alamb/Software/df-target cargo test --all
    Updating crates.io index
   Compiling quote v1.0.11
error[E0599]: no function or associated item named `from_str_unchecked` found for struct `proc_macro2::Literal` in the current scope
   --> /Users/alamb/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/quote-1.0.11/src/runtime.rs:301:41
    |
301 |         let literal = unsafe { Literal::from_str_unchecked(repr) };
    |                                         ^^^^^^^^^^^^^^^^^^ function or associated item not found in `proc_macro2::Literal`

error[E0599]: no function or associated item named `from_str_unchecked` found for struct `proc_macro2::Literal` in the current scope
   --> /Users/alamb/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/quote-1.0.11/src/runtime.rs:310:45
    |
310 |         let mut literal = unsafe { Literal::from_str_unchecked(repr) };
    |                                             ^^^^^^^^^^^^^^^^^^ function or associated item not found in `proc_macro2::Literal`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `quote` due to 2 previous errors

What changes are included in this PR?

Make pin to proc-macro2 more flexble

Are there any user-facing changes?

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
LGTM

@alamb alamb merged commit 3dca969 into apache:master Dec 29, 2021
@alamb
Copy link
Contributor Author

alamb commented Dec 29, 2021

I will prepare a backport of this to active_release in case we can't get @dtolnay to yank the offending quote 1.0.11 release from crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proc-macro2 is hard pinned in arrow-flight
2 participants