Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MutableArrayData support extend decimal data type #1100

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #1099

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 28, 2021
@alamb
Copy link
Contributor

alamb commented Dec 28, 2021

The test failures i think were due to a bad version of quote being pushed: https://github.com/apache/arrow-rs/runs/4647846531?check_suite_focus=true

  Downloaded quote v1.0.11

A fix has been published so I think things should be good now and I will retrigger the tests

@alamb
Copy link
Contributor

alamb commented Dec 28, 2021

Actually, I think we need #1102 (or the crate author to yank that version) to get the tests to pass

@liukun4515
Copy link
Contributor Author

Thanks @alamb
I will rebase the master if your pr merged.

@codecov-commenter
Copy link

Codecov Report

Merging #1100 (726db25) into master (78de3ab) will increase coverage by 0.02%.
The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
+ Coverage   82.32%   82.34%   +0.02%     
==========================================
  Files         168      168              
  Lines       49436    49478      +42     
==========================================
+ Hits        40698    40744      +46     
+ Misses       8738     8734       -4     
Impacted Files Coverage Δ
arrow/src/array/data.rs 81.14% <ø> (+0.29%) ⬆️
arrow/src/array/transform/mod.rs 85.69% <97.67%> (+0.68%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78de3ab...726db25. Read the comment docs.

@alamb alamb merged commit 2ad99ec into apache:master Dec 29, 2021
@liukun4515 liukun4515 deleted the support_extend_decimal branch December 30, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support decimal data type for MutableArrayData
3 participants