Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test test_fuzz_async_reader_selection #2656

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Fix flaky test test_fuzz_async_reader_selection #2656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions parquet/src/arrow/async_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,6 @@ mod tests {
}

#[tokio::test]
#[ignore]
async fn test_fuzz_async_reader_selection() {
let testdata = arrow::util::test_util::parquet_test_data();
let path = format!("{}/alltypes_tiny_pages_plain.parquet", testdata);
Expand All @@ -1015,7 +1014,7 @@ mod tests {
let mut selectors = vec![];

while total_rows < 7300 {
let row_count: usize = rand.gen_range(0..100);
let row_count: usize = rand.gen_range(1..100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So RowSelector.row_count cannot be 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can if you manually construct one as we do in this test but in practice it would be non-sensical (and you wouldn't ever get one if you built a RowSelection from ranges or BooleanArrays). So depending on your perspective we could consider this a bug in the ParquetRecordBatchReader (probably, not sure where the actual issue comes up) but I think if we did the solution would be to just disallow row counts of 0 explicitly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could file a ticket describing the issue, I agree it isn't urgent but it should probably be looked into eventually (as it might unveil other issues).


let row_count = row_count.min(7300 - total_rows);

Expand Down