Speed up i256 division and remainder operations #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tustvold
reviewed
May 30, 2023
| #[derive(Debug)] | ||
| pub struct ParseI256Error {} | ||
| pub enum I256Error { |
There was a problem hiding this comment.
This is a breaking change (which is fine)
There was a problem hiding this comment.
I've filed #4318 to remove this breaking change, PTAL
| if me < you { | ||
| return Ok((Self::from_le_bytes(ret), self)); | ||
| } | ||
|
|
There was a problem hiding this comment.
I wonder if at this point we could fallback to 128-bit division if both the high components are zero?
There was a problem hiding this comment.
The low component is u128. If the high component is zero, it might be possibly over i128 range, no?
There was a problem hiding this comment.
Is that a problem, we have already taken the absolute value, so it is an unsigned division operation?
There was a problem hiding this comment.
Oh, got your idea. You meant to do it in u128.
tustvold
approved these changes
May 31, 2023
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this pull request
May 31, 2023
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this pull request
May 31, 2023
tustvold
added a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4302.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?