Revert i256 error handling changes from #4303 #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
changed the title
tustvold
added
the
development-process
viirya
reviewed
May 31, 2023
| } | ||
| if other == Self::MINUS_ONE && self == Self::MIN { | ||
| return Err(I256Error::DivideOverflow); | ||
| return Err(DivRemError::DivideOverflow); | ||
| } |
There was a problem hiding this comment.
Oh, okay, we don't need new error enum as this is internal. Thanks.
viirya
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I originally was intending to add
non_exhaustiveto the error variant, but realised none of these variants are actually exposed in the public API. I therefore opted to revert the error changes added in #4303 as they don't appear to be necessary.What changes are included in this PR?
Are there any user-facing changes?