-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12444: [Rust] Remove rust #10096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The basic idea looks good to me @jorgecarleitao. Thank you.
The only thing I think may be worth a second set of eyes is the archery integration stuff (but perhaps that is because I don't have a great handle on the integration test plan)
@@ -1,23 +0,0 @@ | |||
# Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this one should be removed @jorgecarleitao -- it might be how rust is run in the integration test framework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK this was only used to call Cargo fmt
from Python; the build of the integration binaries is done by rust_build.sh
; Python calls those binaries without Cargo
.
I also checking the logs, we can find prints such as
##########################################################
IPC: C++ producing, Rust consuming
##########################################################
indicating that Rust is being tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok, I think it is time to merge this PR @jorgecarleitao |
I think that we agreed over the mailing list to not merge this until @kszucs gives green light, post release. I suggest that we take the time to complete the release, confirm that we are in a new development cycle, and then merge this. The rational being that I would like to reduce the risk of pushing merge conflicts to the release manager. |
Yes, please hold off until we merge #10165. |
Rebased :) |
@jorgecarleitao @andygrove @alamb I think we can start to roll-up the rust pull requests now. There are a couple of open ones remaining, I assume we should close those and merge this one. |
Rust releated part should be removed from There is a reference for the rust implementation in I assume the rust post release script should be removed as well There is a |
Thanks @kszucs . I have applied all those changes. |
Thanks @jorgecarleitao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone! I'm merging it, hopefully we didn't forget anything!
Thank you @kszucs |
Removes rust from this repository and uses git clone to fetch the arrow-rs repo for integration tests. Each commit is an independent change. Note: Rust implementations have moved to: * https://github.com/apache/arrow-rs * https://github.com/apache/arrow-datafusion Closes apache#10096 from jorgecarleitao/rm-rust Authored-by: Jorge C. Leitao <[email protected]> Signed-off-by: Krisztián Szűcs <[email protected]>
Removes rust from this repository and uses git clone to fetch the arrow-rs repo for integration tests. Each commit is an independent change. Note: Rust implementations have moved to: * https://github.com/apache/arrow-rs * https://github.com/apache/arrow-datafusion Closes apache#10096 from jorgecarleitao/rm-rust Authored-by: Jorge C. Leitao <[email protected]> Signed-off-by: Krisztián Szűcs <[email protected]>
Removes rust from this repository and uses git clone to fetch the arrow-rs repo for integration tests. Each commit is an independent change. Note: Rust implementations have moved to: * https://github.com/apache/arrow-rs * https://github.com/apache/arrow-datafusion Closes apache#10096 from jorgecarleitao/rm-rust Authored-by: Jorge C. Leitao <[email protected]> Signed-off-by: Krisztián Szűcs <[email protected]>
Removes rust from this repository and uses git clone to fetch the arrow-rs repo for integration tests.
Each commit is an independent change.
Note: Rust implementations have moved to: